linkerd-tcp icon indicating copy to clipboard operation
linkerd-tcp copied to clipboard

Add more client stats

Open stevej opened this issue 8 years ago • 3 comments

Debugging the mystery of the failing iperf tests would have been easier had /metrics shown me that there were other clients connected and where they were connected from.

stevej avatar Apr 28 '17 16:04 stevej

We probably shouldn't expose any per-endpoint metrics by default unless we have a good way of garbage collecting unused enpdpoints (i.e. we'd need to ensure that dropping an endpoint removes its counters, but only after they've been reported... it's a bit tricky).

What non-per-endpoint metrics would have helped you?

olix0r avatar May 02 '17 16:05 olix0r

non-per-endpoint metric: Unique number of currently connected clients.

I would have expected 1 when running my load test with a concurrency of 1. Seeing > 1 would have led me to login to the host and use ss to see who else was connected.

stevej avatar May 03 '17 21:05 stevej

@olix0r this should have been closed by ea507f7.

FYI this doesn't do what you think:

Fixes #1 #2 #3"

Each issue needs its own "fixes":

Fixes #1 Fixes #2 Fixes #3

tamird avatar Jun 17 '17 20:06 tamird