venice icon indicating copy to clipboard operation
venice copied to clipboard

[common][server] Bug fixes and clean of ACL handlers for GRPC

Open mynameborat opened this issue 9 months ago • 0 comments

Summary

  • Consolidate boiler plate code in ACL handlers for access validations
  • Fix code path that throws exception in GRPC and close the calls with the appropriate error messages
  • Fix the flow that invokes onMessage twice in GRPC call intercept to prevent exceptions
  • Rename GrpcSSLUtils to GrpcUtils to accommodate general utility methods
  • Add reflection service to GRPC server to interact with Grpcurl
  • Reuse the header for skipping ACLs from router since the store ACL handling is performed at the router for non FC clients
  • [code readability] Move public methods together followed by overridable and protected methods followed by package private and private methods

How was this PR tested?

  • Unit tests
  • Integration tests
  • Deployment to certification cluster to validate the flow using sample venice application

Does this PR introduce any user-facing changes?

  • [X] No. You can skip the rest of this section.
  • [ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

mynameborat avatar May 13 '24 19:05 mynameborat