shiv icon indicating copy to clipboard operation
shiv copied to clipboard

Make shivs output a little more informative

Open Imaclean74 opened this issue 7 years ago • 4 comments

Just a couple of things that could make the usage experience a little better ;

  • Confirmation that an output file was written. ie generated pyz to <output_file> or similar
  • Flagging of success vs some error condition. I was getting an error for a while - but wasn't entirely sure if it was just a warning - since the last output line is just "done".

If there is agreement that this would be useful I'm happy to put a quick PR together.

Imaclean74 avatar Jun 25 '18 15:06 Imaclean74

Confirmation that an output file was written. ie generated pyz to <output_file> or similar

This would be a welcome addition. Perhaps instead of just "done!" the confirmation could go here?

Flagging of success vs some error condition. I was getting an error for a while - but wasn't entirely sure if it was just a warning - since the last output line is just "done".

Proper exit codes should be being set (via sys.exit)... Curious what the specific error you ran into was, because "done" should indicate that the pyz was built successfully.

lorencarvalho avatar Jun 26 '18 23:06 lorencarvalho

aah - right you are - it didn't output done. Apologies - perhaps I was expecting a more forceful "Failed" error message.

Imaclean74 avatar Jun 27 '18 15:06 Imaclean74

finally got around to making the merge request.

Imaclean74 avatar Jul 29 '18 02:07 Imaclean74

@sixninetynine - I wonder if you could take a look at https://github.com/linkedin/shiv/pull/47 when you get a chance ?

Imaclean74 avatar Aug 07 '18 14:08 Imaclean74