self-focused icon indicating copy to clipboard operation
self-focused copied to clipboard

fix(didRender): force didRender on revisiting same route

Open sarbbottam opened this issue 7 years ago • 1 comments

using a hidden {{link-to}} to force re-render

fixes #2


I noticed, that if there is a {{link-to}} component present in the template, the component is re-rendered on visiting the same route.

Same can be witnessed in the dummy app.

After loading:

  • Click "Topics"
  • Click "Topics"
  • Click "Topics"
  • ...
  • Observe focus state set at the "Topics" level every time.

Thus added a {{link-to}} component wrapped in a div with style display:none.

Using display:none on an element will not only hide it from the display but will also remove it from the accessibility tree.

This will cause the element and all its descendant elements to no longer be announced by screen reading technology.


Issue

issue

Fix

fix

sarbbottam avatar Oct 23 '18 01:10 sarbbottam

@drewlee @stefanpenner could you take a look?

sarbbottam avatar Oct 23 '18 21:10 sarbbottam