rest.li icon indicating copy to clipboard operation
rest.li copied to clipboard

Bug in xxHash

Open leventov opened this issue 8 years ago • 2 comments

You use xxHash.hashInt() here: https://github.com/linkedin/rest.li/blob/35de002f4113b70bee34bb7b61b3cd9bd036eb69/d2/src/main/java/com/linkedin/d2/balancer/util/hashing/MPConsistentHashRing.java#L152

Implementation of this function contains a bug in Zero-allocation Hashing 0.4

Suggested to update to ZAH 0.7 which fixes the bug

leventov avatar Feb 20 '17 07:02 leventov

Thank you for letting us know, we'll try to get to it soon. Do you have a link to the bug?

davidhoa avatar Feb 21 '17 17:02 davidhoa

https://github.com/OpenHFT/Zero-Allocation-Hashing/commit/8a6d6a1162f8a704eb3ffc2648fdae7a39885fcd

leventov avatar Feb 21 '17 18:02 leventov