photon-ml icon indicating copy to clipboard operation
photon-ml copied to clipboard

Remove legacy Photon code

Open ashelkovnykov opened this issue 5 years ago • 3 comments

  • Remove legacy Driver class used for training fixed effect models only
  • Remove all code used only by the above driver
  • Modify AvroDataReader and AvroUtils to load features as NameTermValueAvro objects, instead of GenericRecord objects and then expecting to find certain fields by name

ashelkovnykov avatar Feb 14 '20 20:02 ashelkovnykov

@cmjiang @yunboouyang @lguo Updated for the latest master, requesting review

ashelkovnykov avatar May 09 '20 00:05 ashelkovnykov

Regarding:

Modify AvroDataReader and AvroUtils to load features as NameTermValueAvro objects, instead of GenericRecord objects and then expecting to find certain fields by name

IIRC, the reason we did it this way was that a lot of teams were still using NameTermValueAvro-like schemas to encode feature values, but not exactly NameTermValueAvro.

joshvfleming avatar May 13 '20 02:05 joshvfleming

@joshvfleming My proposed changes (in AvroUtils) are actually specifically looking out for this case. I ran into an issue where if a GenericRecord matched the input schema, but it wasn't the exact output schema, then the cast would fail. So now, we look for all of the schema fields by name but in a generic way where the names aren't hard-coded like before.

ashelkovnykov avatar May 15 '20 23:05 ashelkovnykov