parseq icon indicating copy to clipboard operation
parseq copied to clipboard

Should deprecate(rename)Task.blocking()

Open junchuanwang opened this issue 4 years ago • 2 comments

I recommend we change Task.blocking() to Task.runInExecutor() or Task.callableInexecutor

junchuanwang avatar Nov 17 '20 18:11 junchuanwang

If we change, what about the existing users that will require them to chaneg? These functions are actually task creation, I think if we can consider:

  1. Task.createTaskInThreadPool
  2. Task.createSimpleBlockingTask

how about that

BrianPin avatar Nov 17 '20 18:11 BrianPin

I recommend we change Task.blocking() to Task.runInExecutor() or Task.callableInexecutor

I totally agree with this to be less confusing.

PearlPig123 avatar Feb 23 '21 18:02 PearlPig123