dynamometer icon indicating copy to clipboard operation
dynamometer copied to clipboard

Published 20 hours ago • verified publisher icon linkedin

#63. Dynamometer does not support negative block id's

Open jojochuang opened this issue 7 years ago • 2 comments

Fixes #63 Submitted the PR on behalf of @fangyurao. The PR was adopted from this commit: https://github.com/fangyurao/dynamometer/commit/0f077a6e8094b2154142f09bd034490fbfebfa85

jojochuang avatar Oct 07 '18 20:10 jojochuang

Great find, thanks @jojochuang ! And sorry for the delay in my response.

I think the current logic is a little more verbose than necessary, can we just use Math#floorMod()?

xkrogen avatar Oct 23 '18 21:10 xkrogen

Hey @jojochuang , I put up a patch using Math.floorMod() to make the logic cleaner in PR #83. Can you take a look and see if you think it looks good?

Also cc @fengnanli

xkrogen avatar Feb 27 '19 18:02 xkrogen