dustjs icon indicating copy to clipboard operation
dustjs copied to clipboard

Published 20 hours ago • verified publisher icon linkedin

Performance issue with 2.7.4

Open mrcrgl opened this issue 8 years ago • 2 comments

Hi,

I've found an performance issue in the current 2.7 branch and would fix that. I also found out that the code in master is already restructured and may not be affected anymore. Will the current master be merged in 2.7 or is it worth it to fix that 2.7 branch?

(v8 does not optimise that function) https://github.com/linkedin/dustjs/blob/2.7/lib/parser.js#L268

Marc

mrcrgl avatar Oct 18 '16 08:10 mrcrgl

The parser code is automatically generated by peg.js. Master does use a newer version of peg, but if the code it generates could be optimized you'll probably want to open an issue upstream with peg.

sethkinast avatar Oct 18 '16 17:10 sethkinast

Thank you for help. I didn't tried the newer version yet. Is the release of the master already scheduled?

mrcrgl avatar Oct 19 '16 16:10 mrcrgl