dr-elephant icon indicating copy to clipboard operation
dr-elephant copied to clipboard

Sending empty parameter hashmap in case of retried execution

Open dushyantk1509 opened this issue 5 years ago • 2 comments

When a job is retried, it makes a dummy getCurrentRunParameter call to dr. elephant. In this way tuneIN knows that there was a failure with earlier parameters and penalize the parameters accordingly. In current implementation, best parameters are returned as an output of this dummy call even though we don’t apply these parameters and a new entry is made in tuningJobExecutionParamSet which is not correct.

In this change, empty parameter hash map will return as an output of retried dummy getCurrentRunParameter call and make entry in tuningJobExecutionParamSet only for non-tried executions.

dushyantk1509 avatar Sep 05 '19 10:09 dushyantk1509

@dushyantk1509 Can you mention the problem statement in the Description section of the PR as it will provide more context about the PR. Also the doc link you mentioned above is not accessible for me using my external email-id, can you have a look so that it would be available to all.

ShubhamGupta29 avatar Sep 09 '19 05:09 ShubhamGupta29

@dushyantk1509 Can you mention the problem statement in the Description section of the PR as it will provide more context about the PR. Also the doc link you mentioned above is not accessible for me using my external email-id, can you have a look so that it would be available to all.

Now you won't need docs.

dushyantk1509 avatar Sep 09 '19 12:09 dushyantk1509