cruise-control icon indicating copy to clipboard operation
cruise-control copied to clipboard

Persist demoted and removed brokers

Open morgangalpin opened this issue 1 year ago • 7 comments

This PR implements #2109.

morgangalpin avatar Jan 23 '24 00:01 morgangalpin

Hey @morgangalpin thanks for this!

Do you mind sharing your testing approach/details aside from code tests?

mhratson avatar Feb 01 '24 17:02 mhratson

Sure thing. We've been using it in production for several months now. I've also tried it out on a local dockerized kafka cluster. My manual testing only involved restarting CC to ensure the previous removed/demoted broker state was restored.

morgangalpin avatar Feb 02 '24 22:02 morgangalpin

Got it, let me try reproduce this in my test environment and i'll get back to you…

mhratson avatar Feb 06 '24 16:02 mhratson

@mhratson any progress with trying it out?

morgangalpin avatar Feb 21 '24 20:02 morgangalpin

@mhratson just following up, is there anything else needed before we can merge this change?

morgangalpin avatar Mar 19 '24 23:03 morgangalpin

@CCisGG or @viktorsomogyi, I haven't heard back from @mhratson . Are you able to review and merge this PR?

morgangalpin avatar Apr 16 '24 22:04 morgangalpin

@mhratson @CCisGG Is there anything left to do before merging this PR? Is this even the right medium to communicate about this?

morgangalpin avatar Jun 24 '24 21:06 morgangalpin