cruise-control icon indicating copy to clipboard operation
cruise-control copied to clipboard
verified publisher icon linkedin

bug fix on dot-handled topic names

Open baganokodo2022 opened this issue 3 years ago • 5 comments

We have seen TopicMetrics ccm returned from PrometheusMetricSampler are not dot-handled, which causes "missing topic metrics" on topics with dots in their names, in turn, that blocks CC from generating rebalancing proposals.

This PR is going to fix the above problem related to PrometheusMetricSampler. The change should have not effect on already dot-handled topics.

Thank you

Xinyu Liu

baganokodo2022 avatar Mar 15 '23 20:03 baganokodo2022

@mohitpali Since we are not currently using the PrometheusMetricSampler, would you like to take a look at this one? Thank you!

CCisGG avatar Apr 19 '23 21:04 CCisGG

@CCisGG Looks Good To Me

mohitpali avatar Apr 20 '23 20:04 mohitpali

Hi @baganokodo2022, looks like there are some checkStyle failures. Could you take a look and address them? Thank you!

CCisGG avatar Apr 24 '23 17:04 CCisGG

oops, circleci webpages don't load for me

baganokodo2022 avatar Jun 28 '23 15:06 baganokodo2022

I think the build was outdated after 3 months. @baganokodo2022 could you make another commit to trigger the checks?

CCisGG avatar Jul 26 '23 18:07 CCisGG