cruise-control icon indicating copy to clipboard operation
cruise-control copied to clipboard

Add Vertx.io based API with Swagger UI

Open kismob opened this issue 3 years ago • 9 comments

This PR resolves #1662 This task attempts to tackle the task of introducing an alternative and modern Vertex.io based API parallel to the existing servlet one and based on the existing codebase. The new API will be fully compatible with the currently existing one to ease migration. It is basically just the same API running on Vertx and has a Swagger UI and the existing API documented with Swagger annotations

kismob avatar Aug 24 '21 09:08 kismob

@kismob Thanks for the updates -- just a quick reminder, I can start reviewing the PR once it is marked as Ready for review (i.e. currently it is marked as a Draft).

efeg avatar Aug 31 '21 20:08 efeg

Tank you for the review @viktorsomogyi, I'm fixing the licence texts.

kismob avatar Nov 15 '21 16:11 kismob

@efeg I think we're ready for a code review here. Since this is a big change, how would you prefer to review it? We have a high level document here but if you prefer a recorded demo or something else, let me know.

viktorsomogyi avatar Mar 17 '22 15:03 viktorsomogyi

@kismob would you please rebase the change again to get rid of the conflicts?

viktorsomogyi avatar Mar 17 '22 15:03 viktorsomogyi

@kismob @viktorsomogyi Quick update: Thanks for the PR! I will check out the high-level document, start reviewing this week, and will follow up if further discussion would be needed.

efeg avatar Mar 31 '22 01:03 efeg

@efeg Thanks for the review! I updated the PR based on that.

kismob avatar Apr 05 '22 10:04 kismob

@efeg did you have some time to continue the review? Let me know how can we help to make this easier, I recognise this might be a little big of a bite. I thought if we can agree on the high level design we could split up this feature into multiple smaller commits that might make it easier to review.

viktorsomogyi avatar Apr 26 '22 09:04 viktorsomogyi

Hi @viktorsomogyi -- splitting the PR into smaller, incremental ones would be helpful to get the reviews complete faster.

efeg avatar Apr 27 '22 22:04 efeg

Ok, then we'll raise it in separate PRs. Thanks!

viktorsomogyi avatar May 09 '22 11:05 viktorsomogyi

@viktorsomogyi is that ok if we close this PR as you're splitting it into smaller ones?

CCisGG avatar Aug 14 '22 19:08 CCisGG

@CCisGG yes, it can be closed for now.

viktorsomogyi avatar Aug 16 '22 14:08 viktorsomogyi