cruise-control
cruise-control copied to clipboard
Add Vertx.io based API with Swagger UI
This PR resolves #1662 This task attempts to tackle the task of introducing an alternative and modern Vertex.io based API parallel to the existing servlet one and based on the existing codebase. The new API will be fully compatible with the currently existing one to ease migration. It is basically just the same API running on Vertx and has a Swagger UI and the existing API documented with Swagger annotations
@kismob Thanks for the updates -- just a quick reminder, I can start reviewing the PR once it is marked as Ready for review
(i.e. currently it is marked as a Draft
).
Tank you for the review @viktorsomogyi, I'm fixing the licence texts.
@efeg I think we're ready for a code review here. Since this is a big change, how would you prefer to review it? We have a high level document here but if you prefer a recorded demo or something else, let me know.
@kismob would you please rebase the change again to get rid of the conflicts?
@kismob @viktorsomogyi Quick update: Thanks for the PR! I will check out the high-level document, start reviewing this week, and will follow up if further discussion would be needed.
@efeg Thanks for the review! I updated the PR based on that.
@efeg did you have some time to continue the review? Let me know how can we help to make this easier, I recognise this might be a little big of a bite. I thought if we can agree on the high level design we could split up this feature into multiple smaller commits that might make it easier to review.
Hi @viktorsomogyi -- splitting the PR into smaller, incremental ones would be helpful to get the reviews complete faster.
Ok, then we'll raise it in separate PRs. Thanks!
@viktorsomogyi is that ok if we close this PR as you're splitting it into smaller ones?
@CCisGG yes, it can be closed for now.