cruise-control icon indicating copy to clipboard operation
cruise-control copied to clipboard

Missing EasyMock.verify in unit tests

Open Lincong opened this issue 4 years ago • 3 comments

In some unit tests, before resetting mocked objects or after mocked objects get used, EasyMock.verify does not get invoked on mocked objects. So, we should add it.

For example, in UserTaskManagerTest.java and KafkaCruiseControlServletEndpointTest.java. There could be more cases. So, I suggest thoroughly iterate all cases where EasyMock gets used.

It may require re-writing some unit tests since naively inserting verify before resetting mocks or at the end of unit tests fail in most cases.

Lincong avatar Dec 03 '20 20:12 Lincong

I'll take this on.

ghost avatar Dec 08 '20 20:12 ghost

Hey, is this issue still open?

yamashita-ki avatar Dec 12 '21 04:12 yamashita-ki

Hey I would like to work on this. Can I get started

sachinnandan avatar Mar 26 '23 21:03 sachinnandan