brooklin
brooklin copied to clipboard
Add support for preserving source message timestamp
This feature allows Brooklin to make use of Kafka message's source timestamp when sending the event to destination cluster. If the mirrored topic is configured with message.timestamp.type set to CreateTime, the intent is to have the timestamp supplied by the application. This feature will help achieving this intention.
@celiakung @ahmedahamid could you please review this PR?
@sanjay24 Will do.
thanks @ahmedahamid @somandal
What is the expected timeline for to review this change @ahmedahamid, @somandal? It would be a very useful feature.
Will look into it by end of next week. @mateuszmrozewski
@celiakung could you please check & approve the changes? Thanks
There is still some more work required on this. I'll get back with my discovery and changes
@ahmedahamid @celiakung @somandal KafkaMirrorMakerConnectorTask was translating the records to pass the source event's timestamp only when its timestamp type was "LogAppendTime". Do you know why was it done? I've updated the PR to pass the correct timestamp when the feature is enabled.
@ahmedahamid could we get moving on the review? Also, when is the next Brooklin release planned?
@ahmedahamid Pinging you to get this reviewed and move ahead on this!