ambry icon indicating copy to clipboard operation
ambry copied to clipboard

Make names of variables and functions consistent in PersistentIndex

Open vgkholla opened this issue 9 years ago • 3 comments

PersistentIndex.java uses index and index segment interchangeably to refer to index segments. This creates confusion and inconsistency and affects readability. Change PersistentIndex.java and IndexSegment.java so that all variable and function names are consistent and appropriate.

vgkholla avatar Nov 27 '16 23:11 vgkholla

There are a few suggestions by @pnarayanan on #488 that can be incorporated.

vgkholla avatar Nov 27 '16 23:11 vgkholla

https://github.com/linkedin/ambry/pull/488#discussion_r89040830

vgkholla avatar Nov 28 '16 01:11 vgkholla

Something similar applies to IndexSegment where the concept of segment and index is intermingled in the variable names and would benefit from separating those ideas in the naming.

vgkholla avatar May 25 '18 23:05 vgkholla