Fixed VCR Helix participant didn't report http2 port issue.

[JingQianCloud]

VCR Helix participant didn't report http2 port because VCR_HELIX_CONFIG_READY is true. So add the condition if http2 is added, we also update the Helix.

Tested with server node lva1-app31825.prod.linkedin.com_15098 Now it's reported { "id": "lva1-app31825.prod.linkedin.com_15098", "simpleFields": { "HELIX_ENABLED": "true", "HELIX_ENABLED_TIMESTAMP": "1609888399448", "HELIX_HOST": "lva1-app31825.prod.linkedin.com", "HELIX_PORT": "15098", "http2Port": "15389", "sslPort": "15289", "vcrHelixConfigReady": "true" }, "mapFields": {}, "listFields": {} }

[codecov-commenter]

Codecov Report

Merging #2180 (01ed022) into master (67da981) will decrease coverage by 0.16%. The diff coverage is 67.85%.

@@             Coverage Diff              @@
##             master    #2180      +/-   ##
============================================
- Coverage     73.03%   72.86%   -0.17%     
- Complexity    10214    10226      +12     
============================================
  Files           737      739       +2     
  Lines         56086    56356     +270     
  Branches       6905     6941      +36     
============================================
+ Hits          40960    41064     +104     
- Misses        12916    13065     +149     
- Partials       2210     2227      +17     

Impacted Files	Coverage Δ
...b/ambry/clustermap/RecoveryTestClusterManager.java	0.00% <0.00%> (ø)
...om/github/ambry/cloud/azure/VcrInstanceConfig.java	65.00% <65.00%> (ø)
...github/ambry/cloud/HelixVcrClusterParticipant.java	69.38% <85.71%> (-1.03%)	:arrow_down:
...main/java/com/github/ambry/named/DeleteResult.java	46.15% <0.00%> (-53.85%)	:arrow_down:
.../java/com/github/ambry/named/MySqlNamedBlobDb.java	63.03% <0.00%> (-27.52%)	:arrow_down:
...com/github/ambry/commons/NettySslHttp2Factory.java	87.75% <0.00%> (-10.17%)	:arrow_down:
...java/com/github/ambry/commons/NettySslFactory.java	78.57% <0.00%> (-8.71%)	:arrow_down:
...main/java/com/github/ambry/store/StoreMetrics.java	86.89% <0.00%> (-4.86%)	:arrow_down:
...n/java/com/github/ambry/named/NamedBlobRecord.java	61.53% <0.00%> (-3.47%)	:arrow_down:
...java/com/github/ambry/store/CompactionManager.java	90.90% <0.00%> (-2.85%)	:arrow_down:
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[snalli]

Lets merge this. Please make the logging change by conditionally logging and not overwhelming the log

[JingQianCloud]

@snalli I have another comment to address for this PR. Sorry for the slow response.

[snalli]

@snalli I have another comment to address for this PR. Sorry for the slow response.

ok lmk when done and i will merge

[snalli]

Are there any more comments to be addressed on this ?

[JingQianCloud]

Yes, I need address Justin's comment. Add VcrInstanceConfig data structure. Using its comparison to replace vcrHelixConfigReady.

[snalli]

approved