ambry icon indicating copy to clipboard operation
ambry copied to clipboard

Fix issues related to Simple Operation Tracker response logic

Open mikeyang923 opened this issue 3 years ago • 1 comments

Fix issues related to Simple Operation Tracker response logic:

  1. Return 503 Error instead of NOT_FOUND when there is a success in replica
  2. Set allReplicas to include all replicas regardless of its state

mikeyang923 avatar Aug 13 '22 22:08 mikeyang923

Codecov Report

Merging #2178 (32c1c6a) into master (67da981) will decrease coverage by 19.07%. The diff coverage is 20.00%.

@@              Coverage Diff              @@
##             master    #2178       +/-   ##
=============================================
- Coverage     73.03%   53.95%   -19.08%     
+ Complexity    10214     6894     -3320     
=============================================
  Files           737      737               
  Lines         56086    56088        +2     
  Branches       6905     6906        +1     
=============================================
- Hits          40960    30260    -10700     
- Misses        12916    23187    +10271     
- Partials       2210     2641      +431     
Impacted Files Coverage Δ
...va/com/github/ambry/router/TtlUpdateOperation.java 49.42% <0.00%> (-36.04%) :arrow_down:
...om/github/ambry/router/SimpleOperationTracker.java 56.93% <50.00%> (-36.87%) :arrow_down:
...in/java/com/github/ambry/router/CryptoService.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../java/com/github/ambry/clustermap/PartitionId.java 0.00% <0.00%> (-100.00%) :arrow_down:
...rc/main/java/com/github/ambry/utils/MockClock.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/com/github/ambry/config/JsonAccountConfig.java 0.00% <0.00%> (-100.00%) :arrow_down:
...java/com/github/ambry/utils/ByteBufferChannel.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/com/github/ambry/cloud/azure/AzureMetrics.java 0.00% <0.00%> (-100.00%) :arrow_down:
...a/com/github/ambry/rest/ServerSecurityService.java 0.00% <0.00%> (-100.00%) :arrow_down:
...va/com/github/ambry/server/ServerHealthStatus.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 385 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 13 '22 22:08 codecov-commenter