ambry icon indicating copy to clipboard operation
ambry copied to clipboard

[WIP]Support get chunkId for composite blob

Open SophieGuo410 opened this issue 3 years ago • 5 comments

SophieGuo410 avatar Aug 05 '22 16:08 SophieGuo410

Codecov Report

Merging #2172 (6a2200e) into master (71c99d0) will increase coverage by 14.78%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #2172       +/-   ##
=============================================
+ Coverage          0   14.78%   +14.78%     
- Complexity        0     2287     +2287     
=============================================
  Files             0      736      +736     
  Lines             0    56147    +56147     
  Branches          0     6905     +6905     
=============================================
+ Hits              0     8299     +8299     
- Misses            0    47364    +47364     
- Partials          0      484      +484     
Impacted Files Coverage Δ
...ain/java/com/github/ambry/config/RouterConfig.java 0.00% <0.00%> (ø)
...src/main/java/com/github/ambry/rest/RestUtils.java 0.00% <0.00%> (ø)
...n/java/com/github/ambry/router/GetBlobOptions.java 0.00% <0.00%> (ø)
...in/java/com/github/ambry/router/GetBlobResult.java 0.00% <0.00%> (ø)
.../com/github/ambry/router/GetBlobInfoOperation.java 0.00% <0.00%> (ø)
...java/com/github/ambry/router/GetBlobOperation.java 0.00% <0.00%> (ø)
...ava/com/github/ambry/router/NonBlockingRouter.java 0.00% <0.00%> (ø)
.../github/ambry/router/NonBlockingRouterFactory.java 0.00% <ø> (ø)
...om/github/ambry/router/SimpleOperationTracker.java 0.00% <ø> (ø)
...n/java/com/github/ambry/router/InMemoryRouter.java 0.00% <0.00%> (ø)
... and 737 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 05 '22 16:08 codecov-commenter

I would suggest making this into an "admin" subresource similar to the "Replicas" frontend api instead of a CLI tool. I remember that the CLI tool was a bit hard to get running in an urgent situation, since it requires supplying a lot of configuration.

cgtz avatar Aug 08 '22 16:08 cgtz

yeah, I'll work on it. This is a temporarily work around for this use case.

SophieGuo410 avatar Aug 08 '22 17:08 SophieGuo410

does this need any review or can this be closed ?

snalli avatar Aug 09 '22 18:08 snalli

does this need any review or can this be closed ?

it's a draft pr and it's still work in progress. no need to review for now.

SophieGuo410 avatar Aug 09 '22 18:08 SophieGuo410