ambry icon indicating copy to clipboard operation
ambry copied to clipboard

[Named Blob Migration] Change MySQL related code to be ready for named blob data transition test and verification

Open mikeyang923 opened this issue 3 years ago • 3 comments

This PR change the named blob mysql CRUD logic with newly added fields (version, blob_state). This together with the DB migration will make mysql layer ready for Named Blob Update API. And next step is to utilize the version value in the frontend/router layer and update ambry-client.

mikeyang923 avatar Jun 28 '22 02:06 mikeyang923

Codecov Report

Merging #2143 (d462072) into master (c734656) will decrease coverage by 58.46%. The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #2143       +/-   ##
=============================================
- Coverage     73.22%   14.76%   -58.47%     
+ Complexity    10244     2283     -7961     
=============================================
  Files           736      738        +2     
  Lines         56031    56282      +251     
  Branches       6897     6931       +34     
=============================================
- Hits          41031     8309    -32722     
- Misses        12813    47485    +34672     
+ Partials       2187      488     -1699     
Impacted Files Coverage Δ
...om/github/ambry/config/MySqlNamedBlobDbConfig.java 0.00% <0.00%> (-100.00%) :arrow_down:
...main/java/com/github/ambry/named/DeleteResult.java 0.00% <0.00%> (-100.00%) :arrow_down:
...n/java/com/github/ambry/named/NamedBlobRecord.java 0.00% <0.00%> (-65.00%) :arrow_down:
.../java/com/github/ambry/named/MySqlNamedBlobDb.java 0.00% <0.00%> (-90.56%) :arrow_down:
...om/github/ambry/named/MySqlNamedBlobDbFactory.java 0.00% <0.00%> (-94.74%) :arrow_down:
...in/java/com/github/ambry/named/NamedBlobState.java 0.00% <0.00%> (ø)
.../src/main/java/com/github/ambry/router/Router.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../src/main/java/com/github/ambry/store/Message.java 0.00% <0.00%> (-100.00%) :arrow_down:
...rc/main/java/com/github/ambry/named/PutResult.java 0.00% <0.00%> (-100.00%) :arrow_down:
...rc/main/java/com/github/ambry/quota/QuotaMode.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 585 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jun 28 '22 03:06 codecov-commenter

Does this any reviews or does it need any updates from author ?

snalli avatar Aug 09 '22 17:08 snalli

It's ready for review now. thanks!

mikeyang923 avatar Aug 09 '22 17:08 mikeyang923

Maybe we should introduce a configuration for the new table. So even if we merge the code it will not take affect.

Good idea, done in latest commit.

mikeyang923 avatar Aug 17 '22 02:08 mikeyang923