LiTr icon indicating copy to clipboard operation
LiTr copied to clipboard

Completion never hit

Open ArjunAchatz opened this issue 4 years ago • 1 comments

I have been using this library for a month-ish now (it's 🔥🚒).

I recently found a bug where video trimming never completes. The progress reaches around 0.999874 and then the completion / error / cancel callbacks are not called.

My suspicion is that this is just an arithmetic error. To get around this I wrapped the callback in a suspending cancelable coroutine, and give the coroutine a timeout. Unfortunately that means I consider 0.9999848 a failure, but I imagine under the hood it actually succeeded.

Would be nice to fix this (:

ArjunAchatz avatar May 04 '21 16:05 ArjunAchatz

Glad to hear that you are enjoying LiTr! I will look into this. Is this happening with a particular video? Does that video have non-video or non-audio tracks?

izzytwosheds avatar May 04 '21 18:05 izzytwosheds