l

Results 862 comments of l

@jgm Just checked CommonMark spec, it treats CR, LF and CRLF as line ending: http://spec.commonmark.org/0.28/#line-ending It is one more reason to move `crFilter` out of `readFile`. Currently file with "foo\rbar"...

> If we want not a minimal change, but more correct one, I propose that we change `UTF8.readFile` to read files in binary mode, remove BOM and replace all CRLFs...

@jgm > It's not a no-op! If you use pandoc as a library, you may not be getting your input from UTF8.readFile or UTF8.getContents. That's why `crFilter` needs to be...

Applied to `\include` but not for `\lstinputlisting` for now.

Another failure (on ubuntu-latest), this time about `remove_contact`: ``` assert (msg.get_snapshot()).text == "hi" group.forward_messages([msg]) group.set_draft(text="test draft") draft = group.get_draft() assert draft.text == "test draft" group.remove_draft() assert not group.get_draft() assert group.get_messages()...

Running `while pytest -s tests/test_something.py::test_chat ; do :;done` locally in 3 terminals in parallel eventually fails. Probably one is enough as two failed, running in parallel just makes it fail...

With much more logging I collected these errors: ``` deltachat_rpc_client.rpc.JsonRpcError: {'code': -1, 'message': 'anyhow: Failed to remove contact from chats_contacts table: Failed to EXECUTE SQL query "DELETE FROM chats_contacts WHERE...

WAL documentation has this list of reasons `SQLITE_BUSY` may be returned: https://www.sqlite.org/wal.html#sometimes_queries_return_sqlite_busy_in_wal_mode Seems the list is non-exhaustive. Maybe some connection merges the WAL into the database or something like this.

> probably `write_lock()` is forgotten for a write transaction somewhere or so. We have a very limited API in `sql.rs` that does not allow to just get a connection without...

I tried setting `PRAGMA wal_autocheckpoint=0;` next to `busy_timeout = 0` and it did not help, so it is not about some connection doing WAL checkpointing.