er icon indicating copy to clipboard operation
er copied to clipboard

[Question] Support for Staticman comments

Open VincentTam opened this issue 5 years ago • 5 comments

Hi, this is the author of Beautiful Hugo's Staticman nested comment support halogenica/beautifulhugo#222.

Anyone using this theme would be interested in having Staticman?

VincentTam avatar Nov 23 '18 16:11 VincentTam

Hey, just a heads up, personally I won't merge comments support into the main branch because as mentioned previously I wanted the theme to be quite minimal, but I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

lingxz avatar Nov 24 '18 03:11 lingxz

I'm completely open to having comments support in a separate branch/PR for people to switch to it if they wish to.

Well, this will work too. Thanks for being open to suggestions. :)

rootkea avatar Nov 24 '18 07:11 rootkea

Setting up a separate branch for a new feature will facilitate testing. (git pull origin feature vs git pull origin pull/222/head) Contributors can only propose PR to existing upstream branches. I suggested creating a dev branch as in eduardoboucas/staticman#231 for PR proposals.

VincentTam avatar Nov 24 '18 09:11 VincentTam

yes, I'm just saying I won't merge it, but we can leave it in a separate branch. There's no need for a dev branch for now, you can just raise PR against master.

lingxz avatar Nov 24 '18 09:11 lingxz

I'll try two weeks later.

VincentTam avatar Nov 24 '18 12:11 VincentTam