logging.c:77: bad code for long file names ?

[dcb314]

[logging.c:77]: (error) Dangerous usage of 'buffer' (strncpy doesn't always null-terminate it).

Source code is

    /* delete .old log file */
    strncpy(buffer, log_file, sizeof(buffer) - 1);
    strncat(buffer, ".old", sizeof(buffer) - 1);
    unlink(buffer);

Something like

    /* delete .old log file */
    strncpy(buffer, log_file, sizeof(buffer) - 1 - 4);
    buffer[sizeof(buffer) - 1- 4] = '\0';
    strncat(buffer, ".old", sizeof(buffer) - 1);
    unlink(buffer);

might be better code.