gitstream
gitstream copied to clipboard
Add bot_author checks to skip ETR automation for bot PRs
trafficstars
✨ PR Description
Purpose: Add bot author checks to skip Estimated Time to Review (ETR) automation for bot-created pull requests. Main changes:
- Added bot_author detection rule for identifying automated PR authors using pattern matching
- Updated ETR automation condition to skip processing when PR author is a bot
- Applied consistent bot detection across multiple automation rules for better maintainability
Generated by LinearB AI and added by gitStream. AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
A screenshot of the relevant part of docs after the changes is a life saver 🛟
PR Review: Add bot_author checks to skip ETR automation for bot PRs
Code Quality Assessment: ✅ APPROVE
Positive aspects:
- Consistent implementation of bot_author condition across all relevant automations
- Good reuse of the is.bot_author expression following DRY principles
- Clear intent - effectively excludes bot PRs from ETR automation
- Uses appropriate regex patterns for common bot naming conventions
Potential improvements:
- Consider expanding bot detection patterns to include renovate, greenkeeper, etc.
- The is.bot_author definition is repeated 4 times - could add documentation note about shared conditions
Assessment summary:
- No security risks - only affects automation triggers
- Efficient implementation using short-circuiting some filter
- No performance concerns
- Documentation-only change, no unit tests required
- Low risk, high value improvement
This change effectively prevents ETR automation from running on bot PRs, improving both resource utilization and workflow clarity.
Rating: ✅ APPROVED - Clean implementation following gitStream best practices.