gradle-scripts
gradle-scripts copied to clipboard
Fix gRPC module build failure with duplicate source error
Motivation:
- #132
Modifications:
- Do not add
gen-src/${sourceSet.name}/grpc
to java source set. This will be automatically handled by protobuf plugin. - Do not add
gen-src/${sourceSet.name}/java
if it's already added by protobuf plugin.
Not sure if we should manually add gen-src/${sourceSet.name}/[grpc, java]
to java source set with older version of protobuf plugin.
If so, we should optionally add gen-src/${sourceSet.name}/grpc
to java source set in afterEvaluate
block, too.
Not sure if we should manually add gen-src/${sourceSet.name}/[grpc, java] to java source set with older version of protobuf plugin.
We don't need that. Thanks for the cleaning up. 🙇
Would you mind sending a PR to Armeria first to check if the changes are working correctly? If CI builds pass, you will merge this PR together.
Would you mind sending a PR to Armeria first to check if the changes are working correctly?
I have checked it last night and it worked correctly so we don't need that. 😄
Would you mind sending a PR to Armeria first to check if the changes are working correctly?
But I didn't check the another PR. 😅 https://github.com/line/gradle-scripts/pull/134 Could you follow the direction from @ikhoon, please?
@minwoox @ikhoon Question about the merge process. Should I apply the same change manually to Armeria first and send a PR there first?
Updates: I haven't read @ikhoon's comment carefully. He just wanted to check if CI passes there.
Thaaaaaaanks, @ks-yim 😄