gradle-scripts icon indicating copy to clipboard operation
gradle-scripts copied to clipboard

Fix gRPC module build failure with duplicate source error

Open ks-yim opened this issue 2 years ago • 6 comments

Motivation:

  • #132

Modifications:

  • Do not add gen-src/${sourceSet.name}/grpc to java source set. This will be automatically handled by protobuf plugin.
  • Do not add gen-src/${sourceSet.name}/java if it's already added by protobuf plugin.

ks-yim avatar Oct 18 '22 09:10 ks-yim

Not sure if we should manually add gen-src/${sourceSet.name}/[grpc, java] to java source set with older version of protobuf plugin.

If so, we should optionally add gen-src/${sourceSet.name}/grpc to java source set in afterEvaluate block, too.

ks-yim avatar Oct 18 '22 09:10 ks-yim

Not sure if we should manually add gen-src/${sourceSet.name}/[grpc, java] to java source set with older version of protobuf plugin.

We don't need that. Thanks for the cleaning up. 🙇

minwoox avatar Oct 18 '22 09:10 minwoox

Would you mind sending a PR to Armeria first to check if the changes are working correctly? If CI builds pass, you will merge this PR together.

ikhoon avatar Oct 18 '22 09:10 ikhoon

Would you mind sending a PR to Armeria first to check if the changes are working correctly?

I have checked it last night and it worked correctly so we don't need that. 😄

minwoox avatar Oct 18 '22 09:10 minwoox

Would you mind sending a PR to Armeria first to check if the changes are working correctly?

But I didn't check the another PR. 😅 https://github.com/line/gradle-scripts/pull/134 Could you follow the direction from @ikhoon, please?

minwoox avatar Oct 18 '22 09:10 minwoox

@minwoox @ikhoon Question about the merge process. Should I apply the same change manually to Armeria first and send a PR there first?

Updates: I haven't read @ikhoon's comment carefully. He just wanted to check if CI passes there.

ks-yim avatar Oct 18 '22 09:10 ks-yim

Thaaaaaaanks, @ks-yim 😄

minwoox avatar Nov 28 '22 11:11 minwoox