gradle-scripts
gradle-scripts copied to clipboard
Fix `jvmTarget` & `ktlint` config in `kotlin` flag preset
Motivation:
- #133
Modifications:
- Use
javaTargetCompatibilityproperty value for kotlin compile JVM target. - Use
org.jlleitschuh.gradle.ktlintplugin's defaultktlintversion. - Fix
ktlintfilter exclude condition forgen-srcso that it can properly exclude dynamically attached sources.
It seems impossible to upgrade ktlint version without re-formatting many kotlin code in Armeria.
Testing the change in https://github.com/line/armeria/pull/4488.
It seems it's impossible to upgrade ktlint version without re-formatting many kotlin code in Armeria.
It is necessary, let’s re-format the Kotlin code and upgrade ktlint version.
let’s re-format the Kotlin code and upgrade ktlint version.
+1 Let's re-format everything. 😄 @ks-yim Are you going to finish this up? or we can take it. 😄
@minwoox I can start working on this after a few days (maybe this weekend😊). Let me handle this.
Let me merge this. Thanks a lot, @ks-yim 🙇