gradle-scripts icon indicating copy to clipboard operation
gradle-scripts copied to clipboard

Fix `jvmTarget` & `ktlint` config in `kotlin` flag preset

Open ks-yim opened this issue 3 years ago • 4 comments

Motivation:

  • #133

Modifications:

  • Use javaTargetCompatibility property value for kotlin compile JVM target.
  • Use org.jlleitschuh.gradle.ktlint plugin's default ktlint version.
  • Fix ktlint filter exclude condition for gen-src so that it can properly exclude dynamically attached sources.

ks-yim avatar Oct 18 '22 07:10 ks-yim

It seems impossible to upgrade ktlint version without re-formatting many kotlin code in Armeria.

Testing the change in https://github.com/line/armeria/pull/4488.

ks-yim avatar Oct 18 '22 11:10 ks-yim

It seems it's impossible to upgrade ktlint version without re-formatting many kotlin code in Armeria.

It is necessary, let’s re-format the Kotlin code and upgrade ktlint version.

ikhoon avatar Oct 18 '22 12:10 ikhoon

let’s re-format the Kotlin code and upgrade ktlint version.

+1 Let's re-format everything. 😄 @ks-yim Are you going to finish this up? or we can take it. 😄

minwoox avatar Oct 18 '22 13:10 minwoox

@minwoox I can start working on this after a few days (maybe this weekend😊). Let me handle this.

ks-yim avatar Oct 19 '22 03:10 ks-yim

Let me merge this. Thanks a lot, @ks-yim 🙇

minwoox avatar Nov 28 '22 11:11 minwoox