cosmwasm icon indicating copy to clipboard operation
cosmwasm copied to clipboard

Function name "set_dynamic_callstack" is not good

Open loloicci opened this issue 7 months ago • 0 comments

https://github.com/Finschia/cosmwasm/blob/a5f8b5ffe581cd56a73922a460197d2913ac1c61/packages/vm/src/environment.rs#L380-L381

The name set_dynamic_callstack is not good.

  1. set_dynamic_callstack not only sets the call stack but also validates that the call stack does not have the called contract's address.
  2. set_dynamic_callstack adds the called contract's address to the top of the call stack rather than sets.

Renaming this function's name affects wasmvm (https://github.com/Finschia/wasmvm/blob/1e43355ed2255e4aed7fabb2e4323caa2bd3e02a/libwasmvm/src/dynamic_link.rs#L152).

loloicci avatar Jul 08 '24 09:07 loloicci