conflr icon indicating copy to clipboard operation
conflr copied to clipboard

In larger tables, columns become collapsed on top of each other

Open stevenlockton-progenity opened this issue 2 years ago • 10 comments

Hello,

When tables (printed by knitr::kable()) become a certain size some columns collapse together. It's an odd bug that has only recently become apparent.

Here's what I expect (3 x 10 table example used) image

And here's what happens (22 x 50 table example) image

Here is some code to reproduce the bug that can be used in a conflr confluence_document.

make_fake_data_table <- function(nrows, ncolumns) {
  set.seed(123)
  n <- ncolumns * nrows
  mx <- matrix(
    data = rnorm(n),
    nrow = nrows,
    ncol = ncolumns
  )
  df <- data.frame(
    A = 1:nrows,
    B = letters[1:nrows],
    C = factor(LETTERS[1:nrows]),
    mx
  )
  return(df)
}

fake_dt <- make_fake_data_table(
  nrows = 22,
  ncolumns = 50
)

knitr::kable(fake_dt)

At some size of data frame this issue goes away - it's not a simple "below x columns it's fine" because it also depends on the row number too. I haven't yet pinpointed that place (working on it!).

Any ideas on what's causing this?

stevenlockton-progenity avatar Sep 21 '21 18:09 stevenlockton-progenity

Thanks for reporting! I have no idea on conflr's side. If you manually create 22 x 50 table on editor, what will happen? As you say

It's an odd bug that has only recently become apparent.

I'm wondering if this is something on Confluence's side.

yutannihilation avatar Sep 22 '21 00:09 yutannihilation

Hey - I copy and pasted a big table full of random numbers from excel with no issues. I haven’t manually created a table with confluences table tool. I’ll try.

I’m guessing it’s something to do with atlassian’s recent api updates. Is there anything in the md file that you can see that conflr would struggle with?

S


From: Hiroaki Yutani @.> Sent: Tuesday, September 21, 2021 5:57:59 PM To: line/conflr @.> Cc: Steven Lockton @.>; Author @.> Subject: Re: [line/conflr] In larger tables, columns become collapsed on top of each other (#137)

Thanks for reporting! I have no idea on conflr's side. If you manually create 22 x 50 table on editor, what will happen? As you say

It's an odd bug that has only recently become apparent.

I'm wondering if this is something on Confluence's side.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fline%2Fconflr%2Fissues%2F137%23issuecomment-924496230&data=04%7C01%7Csteven.lockton%40progenity.com%7C16619ec689e94bfdca0408d97d640608%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678690829092139%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Gq78LfRdE017KNBNyKousDGyira3vZ4glyw2W78tYtw%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKJPPJEWQXF34JFTJT7MNDDUDESZPANCNFSM5EPFHOIA&data=04%7C01%7Csteven.lockton%40progenity.com%7C16619ec689e94bfdca0408d97d640608%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678690829102133%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WlTonIalB04oRcIF2ggdOACEVT7QmfVI6JvBy1%2Fc5Gw%3D&reserved=0.

IMPORTANT: This email (and any attachments) is intended for the use of only the person or entity to which it is addressed, and may contain information that is privileged and confidential. You, the recipient, are obligated to maintain it in a safe, secure and confidential manner. Unauthorized redisclosure or failure to maintain confidentiality may subject you to federal and state penalties. If you are not the intended recipient, please immediately notify us by return email, and delete this message from your computer.

stevenlockton-progenity avatar Sep 22 '21 01:09 stevenlockton-progenity

I’m guessing it’s something to do with atlassian’s recent api updates.

Ah, this sounds possible... Thanks. I know one recent API change on Confluence Cloud https://github.com/line/conflr/issues/125#issuecomment-921688057, they changed the default editor to the new one, so it might matter here. Do you use Confluence Cloud?

yutannihilation avatar Sep 22 '21 01:09 yutannihilation

Yes we do. We preferred the old editor, it’s more compact and allows for code hiding. Is there a way to optionally use the old editor in conflr now the new editor is the default?

S


From: Hiroaki Yutani @.> Sent: Tuesday, September 21, 2021 6:28:22 PM To: line/conflr @.> Cc: Steven Lockton @.>; Author @.> Subject: Re: [line/conflr] In larger tables, columns become collapsed on top of each other (#137)

I’m guessing it’s something to do with atlassian’s recent api updates.

Ah, this sounds possible... Thanks. I know one recent API change on Confluence Cloud #125 (comment)https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fline%2Fconflr%2Fissues%2F125%23issuecomment-921688057&data=04%7C01%7Csteven.lockton%40progenity.com%7Cdf52e27f85f344806b4708d97d68450a%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678709051432484%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fFJARdFoL84Dkw6DpTxu%2FBwqHJ%2F%2BAYcBg1%2FUjRCPhW0%3D&reserved=0, they changed the default editor to the new one, so it might matter here. Do you use Confluence Cloud?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fline%2Fconflr%2Fissues%2F137%23issuecomment-924508344&data=04%7C01%7Csteven.lockton%40progenity.com%7Cdf52e27f85f344806b4708d97d68450a%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678709051442481%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tGed3chVQyHbNAC7fDJPq5J67hvB%2BWdmtlADMxVxAVw%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKJPPJBE4XM43AF4VSDC3GTUDEWLNANCNFSM5EPFHOIA&data=04%7C01%7Csteven.lockton%40progenity.com%7Cdf52e27f85f344806b4708d97d68450a%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678709051442481%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=XkYI7vxrq4GbxWI2MlgsIwP35bDSTbpIG4ClKC9AUx0%3D&reserved=0.

IMPORTANT: This email (and any attachments) is intended for the use of only the person or entity to which it is addressed, and may contain information that is privileged and confidential. You, the recipient, are obligated to maintain it in a safe, secure and confidential manner. Unauthorized redisclosure or failure to maintain confidentiality may subject you to federal and state penalties. If you are not the intended recipient, please immediately notify us by return email, and delete this message from your computer.

stevenlockton-progenity avatar Sep 22 '21 01:09 stevenlockton-progenity

No option at the moment. I need to implement the feature to switch between new and old, but I couldn't find time for this, sorry. Still not sure if using the old editor will solve this issue, but I'll try to implement it, hopefully soon. Feel free to ping me for this!

yutannihilation avatar Sep 22 '21 01:09 yutannihilation

I’d be very interested in that feature. Atlassian are painfully slow to fix anything so I’d rather switch back to what works than rely on them to fix the new default.


From: Hiroaki Yutani @.> Sent: Tuesday, September 21, 2021 6:34:04 PM To: line/conflr @.> Cc: Steven Lockton @.>; Author @.> Subject: Re: [line/conflr] In larger tables, columns become collapsed on top of each other (#137)

No option at the moment. I need to implement the feature to switch between new and old, but I couldn't find time for this, sorry. Still not sure if using the old editor will solve this issue, but I'll try to implement it, hopefully soon. Feel free to ping me for this!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fline%2Fconflr%2Fissues%2F137%23issuecomment-924510330&data=04%7C01%7Csteven.lockton%40progenity.com%7C176a6741d15f47bf272e08d97d691083%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678712463438306%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SyM1QauhDl4bzn8rp9ENIwCwZSVrghu7FMVZIXhcaSA%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKJPPJCRSXTKJGFCGZM2APLUDEXAZANCNFSM5EPFHOIA&data=04%7C01%7Csteven.lockton%40progenity.com%7C176a6741d15f47bf272e08d97d691083%7C0666349c4979449297792a34e68103b3%7C0%7C0%7C637678712463448302%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cOFobZ%2Fk0LgGD8mBA8Mnhqz2elzg8qrau83MM48tBko%3D&reserved=0.

IMPORTANT: This email (and any attachments) is intended for the use of only the person or entity to which it is addressed, and may contain information that is privileged and confidential. You, the recipient, are obligated to maintain it in a safe, secure and confidential manner. Unauthorized redisclosure or failure to maintain confidentiality may subject you to federal and state penalties. If you are not the intended recipient, please immediately notify us by return email, and delete this message from your computer.

stevenlockton-progenity avatar Sep 22 '21 01:09 stevenlockton-progenity

If you need help with this feature (namely, selecting which editor to use when publishing to confluence cloud), let me know. I might be able to assist. When do you think you'd be able to work on this?

stevenlockton-progenity avatar Sep 22 '21 21:09 stevenlockton-progenity

No idea, hopefully next week, or next month :)

yutannihilation avatar Sep 23 '21 07:09 yutannihilation

@stevenlockton-progenity Sorry for the delay, I created a new space on Confluence Cloud and tested. A good news is that I can reproduce your issue so I guess it's a problem on Confluence's side. A bad news is, however, I couldn't find the way to publish it in the legacy editor...

It seems this requires the owner to ask Atlassian to enable the legacy editor. Considering this, I feel this is not what I can expect is available on the usual setup, so I'm deciding not to provide this "switch" feature.

https://community.atlassian.com/t5/Confluence-questions/I-have-the-new-editor-is-it-possible-to-have-the-legacy-editor/qaq-p/1372761

An workaround for this particular issue seems that we can change the width setting (sorry the caption is in Japanese) by clicking this. Of course, it's annoying that we have to edit the page every time we publish wide tables, but this might be a bit better than the status quo...

image

yutannihilation avatar Oct 23 '21 11:10 yutannihilation

Thanks @yutannihilation!

I don't often make huge, wide tables, so this is perhaps a good workaround.

stevenlockton-progenity avatar Oct 25 '21 16:10 stevenlockton-progenity