centraldogma icon indicating copy to clipboard operation
centraldogma copied to clipboard

Add integration test for Spring Cloud Config Server

Open minwoox opened this issue 9 months ago • 3 comments

We've implemented Git clone-related operations in #954. It would be nice to add integration tests with Spring Cloud Config Server to ensure compatibility as @trustin suggested. https://github.com/line/centraldogma/pull/954#pullrequestreview-2047397993 https://docs.spring.io/spring-cloud-config/docs/current/reference/html/#_spring_cloud_config_server

minwoox avatar May 09 '24 08:05 minwoox

hello. This is my first time here 😎

How much compatibility with spring-cloud-config-server are you thinking about? Do you have any plans to add server-specific modules?

heowc avatar May 10 '24 10:05 heowc

Hey, great to see you! 😆

I think it makes sense to start with the basics outlined in the Spring Cloud Config Quick Start guide. From there, we can expand to support pattern matching and search paths as described in the following sections:

Pattern Matching and Multiple Repositories Placeholders in Git Search Paths Do you have any suggestions on other areas we should focus on or any additional resources we should refer to?"

minwoox avatar May 10 '24 13:05 minwoox

I was just curious about the plan. I think it's a good start... If it integrates with spring, I'll be looking into it to utilize it in my service :)

My service is used in combination with spring-cloud-bus

  • https://spring.io/projects/spring-cloud-bus

heowc avatar May 11 '24 12:05 heowc