centraldogma
centraldogma copied to clipboard
Fix history displays irrelevant changes
Motivate:
The history of a directory includes changes in directories share the name. For instance: the history of /foo
displays changes for /foo2
, /foo3
, /foobar
...
Modifications:
Add a slash (/)
before **
in the path (path + "/**")
. The pattern foo/**
matches /foo/anything
, /foo/subdir/file
, but it does not match anything that isn't a subpath of /foo
.
Result Fixes https://github.com/line/centraldogma/issues/902
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.52%. Comparing base (
ac1e8c1
) to head (0eae756
). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #922 +/- ##
============================================
+ Coverage 66.78% 67.52% +0.74%
- Complexity 3513 3567 +54
============================================
Files 370 370
Lines 14476 14477 +1
Branches 1553 1553
============================================
+ Hits 9668 9776 +108
+ Misses 3929 3821 -108
- Partials 879 880 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could you also check if ContentServiceV1
correctly works, please?
Could you also check if
ContentServiceV1
correctly works, please?
Ok, let me check
Thanks! Could you add some tests, please? 😉
Sure, let me try.
Hi @minwoox I try to create a CentralDogmaExtension like RepositoryServiceV1Test
to test /api/v0/
, but it always returns 404, seem it doesn't support /api/v0
. Could you help me with this?