centraldogma
centraldogma copied to clipboard
Support local-to-remote mirroring
Motivation We currently support only remote-to-local mirroring. We should support the opposite direction as well.
Modifications:
- Implement
GitMirror#mirrorToLocalRemote()
which used to throwUnsupportedOperationException
before.
Result:
- Close #53
- You can now enable mirroring from Central Dogma to a remote Git server.
Codecov Report
Base: 64.95% // Head: 65.11% // Increases project coverage by +0.15%
:tada:
Coverage data is based on head (
52187d1
) compared to base (0cf990c
). Patch coverage: 79.46% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #717 +/- ##
============================================
+ Coverage 64.95% 65.11% +0.15%
- Complexity 3227 3259 +32
============================================
Files 349 349
Lines 13474 13670 +196
Branches 1454 1485 +31
============================================
+ Hits 8752 8901 +149
- Misses 3896 3928 +32
- Partials 826 841 +15
Impacted Files | Coverage Δ | |
---|---|---|
...erver/internal/mirror/DefaultMirroringService.java | 65.90% <0.00%> (ø) |
|
...ntraldogma/server/internal/mirror/MirrorState.java | 100.00% <ø> (ø) |
|
...inecorp/centraldogma/server/mirror/MirrorUtil.java | 76.47% <ø> (ø) |
|
...centraldogma/server/internal/mirror/GitMirror.java | 79.09% <80.00%> (-0.17%) |
:arrow_down: |
...necorp/centraldogma/testing/internal/TestUtil.java | 83.33% <100.00%> (+1.51%) |
:arrow_up: |
...aldogma/client/armeria/CompositeEndpointGroup.java | 75.00% <0.00%> (-18.75%) |
:arrow_down: |
...centraldogma/server/internal/api/WatchService.java | 76.27% <0.00%> (-3.39%) |
:arrow_down: |
.../linecorp/centraldogma/client/AbstractWatcher.java | 76.00% <0.00%> (-2.67%) |
:arrow_down: |
...ntraldogma/server/internal/mirror/GitWithAuth.java | 31.25% <0.00%> (+0.89%) |
:arrow_up: |
... and 1 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ikhoon Addressed all the comments. 😉
The master branch is merged into the working branch to run in Apple Silicon.
Thanks, @ikhoon and @jrhee17 for reviewing. 😉