centraldogma icon indicating copy to clipboard operation
centraldogma copied to clipboard

Display the original commit message when mirroring

Open minwoox opened this issue 2 years ago • 1 comments

Currently, the commit message of a commit that is pushed by the mirroring task looks like this:

Mirror fbee605, git+ssh://github.com/xxx.git#master to the repository 'foo'

It does not contain the original commit message which is useful to users. It would be nice if we can display the original commit message. We can retrieve the message via:

Iterable<RevCommit> call = git.log().setMaxCount(1).call();

minwoox avatar Aug 16 '22 14:08 minwoox

We might display the message using the detail field. However, the current UI does not display it so we should revamp the UI beforehand.

minwoox avatar Aug 16 '22 14:08 minwoox

There might be more than 1 commit involved in a mirroring attempt. Should we show every commit message (up to N commits)?

trustin avatar Feb 14 '23 02:02 trustin

Should we show every commit message (up to N commits)?

That's a good idea.

minwoox avatar Feb 14 '23 03:02 minwoox

At second thought, we probably should show the latest one only, given we're going to use shallow clone and shallow fetch (see #801).

trustin avatar Mar 02 '23 10:03 trustin

From my understanding, here is the pr: https://github.com/line/centraldogma/pull/818 Please help review 🤗

thachlp avatar Mar 07 '23 03:03 thachlp

Closed via #818 Thanks, @thachlp!

trustin avatar Apr 17 '23 08:04 trustin