centraldogma icon indicating copy to clipboard operation
centraldogma copied to clipboard

Bump Gradle version to 7.5

Open ikhoon opened this issue 1 year ago • 2 comments

Motivation:

The Gradle version of Central Dogma was stuck in 6.x version because the two Gradle plugins didn't work with Gradle 7.

  • craigburke/client-dependencies-gradle#106
  • gogradle/gogradle#328 So we need to migrate the obsolete plugins to move on Gradle 7

Modifications:

  • Upgrade Gradle version to 7.5 from 6.8.3
  • Remove :cli module and download cli binaries from the Central Dogma Go release page. https://github.com/line/centraldogma-go/releases/tag/0.0.1
  • Migrate com.craigburke.client-dependencies into com.github.node-gradle.node:
    • Define dependendies using package.json.
    • Relocate js files in node_modules to vender folder.

Result:

Reduce technical debt

ikhoon avatar Aug 09 '22 13:08 ikhoon

IntelliJ PR review is recommanded to fold/hide the changes in gradle/scripts image

ikhoon avatar Aug 10 '22 02:08 ikhoon

Codecov Report

Merging #707 (4ed8826) into master (f3b2b07) will increase coverage by 0.09%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #707      +/-   ##
============================================
+ Coverage     70.20%   70.30%   +0.09%     
  Complexity     3420     3420              
============================================
  Files           349      349              
  Lines         13482    13470      -12     
  Branches       1456     1454       -2     
============================================
+ Hits           9465     9470       +5     
- Misses         3137     3138       +1     
+ Partials        880      862      -18     
Impacted Files Coverage Δ
...gma/testing/internal/CentralDogmaRuleDelegate.java 70.58% <ø> (+0.82%) :arrow_up:
...server/internal/thrift/CentralDogmaExceptions.java 50.00% <0.00%> (-13.64%) :arrow_down:
...ient/armeria/legacy/LegacyCentralDogmaBuilder.java 81.48% <0.00%> (-3.71%) :arrow_down:
...centraldogma/server/internal/api/WatchService.java 76.27% <0.00%> (-3.39%) :arrow_down:
...internal/storage/DirectoryBasedStorageManager.java 64.19% <0.00%> (-0.88%) :arrow_down:
...in/java/com/linecorp/centraldogma/server/Main.java 0.00% <0.00%> (ø)
...internal/storage/repository/git/GitRepository.java 76.03% <0.00%> (+0.09%) :arrow_up:
...internal/replication/ZooKeeperCommandExecutor.java 78.55% <0.00%> (+0.14%) :arrow_up:
...com/linecorp/centraldogma/server/CentralDogma.java 77.46% <0.00%> (+0.18%) :arrow_up:
.../centraldogma/server/metadata/MetadataService.java 90.61% <0.00%> (+0.20%) :arrow_up:
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 06:08 codecov[bot]