Support for automatic retry
Motivation
- Apply retryer to
BaseClient - #46
Modifications
- Use third-party library,
tenacity, to retry at client. It helps to reduce boiler plate and feature implementations such as exponential backoff.- Add related tests,
test_get_with_retry_by_response,test_get_with_retry_by_clientat "test_base_client.py".
- Add related tests,
- Bump version to 0.4.0
- @ikhoon After this PR, I would like to publish 0.4.0. If you have different opinion, please tell me about the idea.
- misc.
- Refactor not to write repetitive hard coded.
- Apply
retriesoption for integration test client for flaky tests. #42
Result
- Close #46
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.80%. Comparing base (
045d77a) to head (0d9f565). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 93.74% 93.80% +0.06%
==========================================
Files 23 23
Lines 703 710 +7
==========================================
+ Hits 659 666 +7
Misses 44 44
| Flag | Coverage Δ | |
|---|---|---|
93.80% <100.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I would like to publish 0.4.0. If you have different opinion, please tell me about the idea.
We are on the same page. :-)
if main branch testing fixed. I think it's good to deploy
if main branch testing fixed
@darjeeling I hope so. It may help tests to be more robust. Still tests for watch seems flaky though.