armeria icon indicating copy to clipboard operation
armeria copied to clipboard

[POC] Allow clients to specify set TLS specifications per-request

Open jrhee17 opened this issue 4 months ago • 3 comments

Motivation:

Explain why you're making this change and what problem you're trying to solve.

Modifications:

  • List the modifications you've made in detail.

Result:

  • Closes #<GitHub issue number>. (If this resolves the issue.)
  • Describe the consequences that a user will face after this PR is merged.

jrhee17 avatar Nov 25 '25 02:11 jrhee17

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 25 '25 02:11 coderabbitai[bot]

🔍 Build Scan® (commit: 4ae8b6a027705204c665ffef31d20135f834a4f7)

Job name Status Build Scan®
build-ubicloud-standard-16-jdk-8 https://ge.armeria.dev/s/evwvkqmdclan6
build-ubicloud-standard-16-jdk-25 https://ge.armeria.dev/s/rsgag3x5pcnrw
build-ubicloud-standard-16-jdk-21-snapshot-blockhound https://ge.armeria.dev/s/kiikgstwduwpi
build-ubicloud-standard-16-jdk-17-min-java-17-coverage https://ge.armeria.dev/s/3b6w2tt2pzrjg
build-ubicloud-standard-16-jdk-17-min-java-11 https://ge.armeria.dev/s/ysylmtep57epc
build-ubicloud-standard-16-jdk-17-leak https://ge.armeria.dev/s/63cr72ww7drmg
build-ubicloud-standard-16-jdk-11 https://ge.armeria.dev/s/gtzjf6synnx42
build-macos-latest-jdk-25 https://ge.armeria.dev/s/46oh3c5kp3q7u

github-actions[bot] avatar Nov 25 '25 03:11 github-actions[bot]

Codecov Report

:x: Patch coverage is 75.94502% with 70 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.27%. Comparing base (8150425) to head (4ae8b6a). :warning: Report is 284 commits behind head on main.

Files with missing lines Patch % Lines
...om/linecorp/armeria/client/DefaultSslContexts.java 0.00% 30 Missing :warning:
...ava/com/linecorp/armeria/server/ServerTlsSpec.java 70.27% 6 Missing and 5 partials :warning:
.../linecorp/armeria/server/VirtualHostTlsSetter.java 86.04% 1 Missing and 5 partials :warning:
...p/armeria/internal/common/util/SslContextUtil.java 87.80% 2 Missing and 3 partials :warning:
...om/linecorp/armeria/server/VirtualHostBuilder.java 87.87% 2 Missing and 2 partials :warning:
...linecorp/armeria/client/DefaultRequestOptions.java 66.66% 2 Missing :warning:
...a/client/FutureTransformingRequestPreparation.java 0.00% 2 Missing :warning:
...linecorp/armeria/client/RestClientPreparation.java 0.00% 2 Missing :warning:
...armeria/client/TransformingRequestPreparation.java 0.00% 2 Missing :warning:
...orp/armeria/internal/common/SslContextFactory.java 95.55% 0 Missing and 2 partials :warning:
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6516      +/-   ##
============================================
- Coverage     74.46%   74.27%   -0.19%     
- Complexity    22234    23560    +1326     
============================================
  Files          1963     2117     +154     
  Lines         82437    88192    +5755     
  Branches      10764    11543     +779     
============================================
+ Hits          61385    65508    +4123     
- Misses        15918    17183    +1265     
- Partials       5134     5501     +367     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 25 '25 07:11 codecov[bot]