armeria
armeria copied to clipboard
DNS resolution happens before connection pool lookup
Motivation: repro of https://github.com/line/armeria/issues/6444 Explain why you're making this change and what problem you're trying to solve.
Modifications:
- List the modifications you've made in detail.
Result:
- Closes #<GitHub issue number>. (If this resolves the issue.)
- Describe the consequences that a user will face after this PR is merged.
🔍 Build Scan® (commit: bb0a688de542f76404509709bba5d1d39ab5698a)
| Job name | Status | Build Scan® |
|---|---|---|
| build-ubicloud-standard-16-jdk-8 | ✅ | https://ge.armeria.dev/s/co5vvijfhfh3k |
| build-ubicloud-standard-16-jdk-21-snapshot-blockhound | ✅ | https://ge.armeria.dev/s/zbbuy56bclifa |
| build-ubicloud-standard-16-jdk-17-min-java-17-coverage | ✅ | https://ge.armeria.dev/s/wn26zg4wpx7nu |
| build-ubicloud-standard-16-jdk-17-min-java-11 | ✅ | https://ge.armeria.dev/s/sbikcx5lufmzs |
| build-ubicloud-standard-16-jdk-17-leak | ✅ | https://ge.armeria.dev/s/xco52wgrdgu4u |
| build-ubicloud-standard-16-jdk-11 | ✅ | https://ge.armeria.dev/s/ndpi6rrkskyi2 |
| build-macos-latest-jdk-21 | ✅ | https://ge.armeria.dev/s/vesqbox22ecya |
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.11%. Comparing base (8150425) to head (bb0a688).
:warning: Report is 264 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6443 +/- ##
============================================
- Coverage 74.46% 74.11% -0.35%
- Complexity 22234 23001 +767
============================================
Files 1963 2061 +98
Lines 82437 86135 +3698
Branches 10764 11312 +548
============================================
+ Hits 61385 63841 +2456
- Misses 15918 16879 +961
- Partials 5134 5415 +281
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.