armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Support for gRPC health check endpoint

Open ikhoon opened this issue 1 year ago • 6 comments

It would be useful to have a GrpcHealthcheckedEndpointGroup to use gRPC health checks in the Armeria gRPC client.

public class GrpcHealthcheckedEndpointGroupBuilder extends AbstractHealthCheckedEndpointGroupBuilder {

    protected abstract Function<? super HealthCheckerContext, ? extends AsyncCloseable> newCheckerFactory() {
        return new GrpcHealthCheckerFactory(...);
   }

}

ikhoon avatar Oct 02 '24 05:10 ikhoon

Hi @ikhoon, I'd like to work on this issue as my first contribution to the project. Could you please let me know if it's okay to proceed?

minkichoe avatar Oct 09 '24 08:10 minkichoe

For sure. 👍

ikhoon avatar Oct 10 '24 09:10 ikhoon

Reference: https://grpc.io/docs/guides/health-checking/

ikhoon avatar Oct 10 '24 09:10 ikhoon

Can I take this up if nobody is working on it?

asharan2buff avatar Nov 13 '24 04:11 asharan2buff

If you’re interested in my opinion, yes, you can take it.

minkichoe avatar Nov 13 '24 04:11 minkichoe

Can I take this up if nobody is working on it?

It seems no one is working on this issue. Welcome.

ikhoon avatar Nov 13 '24 05:11 ikhoon