armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Add option to respect the marshaller specified in gRPC MethodDescriptor

Open jaeseung-bae opened this issue 2 years ago โ€ข 1 comments

Motivation:

  • This PR adds option to use marshaller that specified in gRPC MethodDescriptor
  • Related Issue #5103
    • Partial solved: Option to use marshaller that specified in gRPC MethodDescriptor
    • Unsolved part: Provide way to add custom marshaller

Modifications:

  • New option useMethodMarshaller
    • default value is false
  • Add validate logic for GrpcServiceBuilder and GrpcClientBuilder to check that unsafeWrapDeserializedBuffer and useMethodMarshaller are mutually exclusive

Result:

  • Have new option useMethodMarshaller
  • Throw IllegalStateException when both unsafeWrapDeserializedBuffer and useMethodMarshaller are enabled

jaeseung-bae avatar Apr 22 '24 14:04 jaeseung-bae

๐Ÿ” Build Scanยฎ (commit: 33b67a44b0866d5bd4233a5d3874fca010214020)

Job name Status Build Scanยฎ
build-windows-latest-jdk-21 โœ… https://ge.armeria.dev/s/c3t44iglkfbhy
build-self-hosted-unsafe-jdk-8 โœ… https://ge.armeria.dev/s/4r3nstqem5kew
build-self-hosted-unsafe-jdk-21-snapshot-blockhound โœ… https://ge.armeria.dev/s/gkmvjbkvtpeyi
build-self-hosted-unsafe-jdk-17-min-java-17-coverage โœ… https://ge.armeria.dev/s/ixyeas4apsboo
build-self-hosted-unsafe-jdk-17-min-java-11 โœ… https://ge.armeria.dev/s/dfrsbi6sxrzok
build-self-hosted-unsafe-jdk-17-leak โœ… https://ge.armeria.dev/s/i3ke73bcj5x72
build-self-hosted-unsafe-jdk-11 โœ… https://ge.armeria.dev/s/kwk5fwzm2am4o
build-macos-12-jdk-21 โœ… https://ge.armeria.dev/s/zagkltchhibgs

github-actions[bot] avatar Apr 22 '24 16:04 github-actions[bot]

@jaeseung-bae ๐Ÿ‘ ๐Ÿ‘ ๐Ÿ‘

minwoox avatar May 16 '24 07:05 minwoox