armeria
armeria copied to clipboard
Add CoroutineHttpService for handle request within Coroutine suspend
Motivation:
- Closes https://github.com/line/armeria/issues/5442
Modifications:
- Add CoroutineHttpService implements HttpService
Result:
- Closes #5442.
- Provide
HttpService
based on coroutine suspend throughCoroutineHttpService
(without the boiler plate code that apply the coroutine)
๐ Build Scanยฎ (commit: e6682de62d49e69eb752db0b930a73bc6cd45c14)
Job name | Status | Build Scanยฎ |
---|---|---|
build-windows-latest-jdk-19 | โ | https://ge.armeria.dev/s/zojch5uec6dhw |
build-self-hosted-unsafe-jdk-8 | โ | https://ge.armeria.dev/s/nqhmsrv4neqhk |
build-self-hosted-unsafe-jdk-19-snapshot-blockhound | โ | https://ge.armeria.dev/s/pus6jhtx3raxq |
build-self-hosted-unsafe-jdk-17-min-java-17-coverage | โ | https://ge.armeria.dev/s/45svkkdbccr4i |
build-self-hosted-unsafe-jdk-17-min-java-11 | โ | https://ge.armeria.dev/s/udl5gituxyfgy |
build-self-hosted-unsafe-jdk-17-leak | โ | https://ge.armeria.dev/s/gkmlfqmha6pgo |
build-self-hosted-unsafe-jdk-11 | โ | https://ge.armeria.dev/s/nlqy5u7u44pj2 |
build-macos-12-jdk-19 | โ | https://ge.armeria.dev/s/umtvthnggpamc |
Looks great! How about also adding extension methods in this PR as well? ๐
Does the extension method here refer to the extension function of the ServerBuilder
?
Right. Should we add coroutineService
for ServerBuilder
, VirtualHostBuilder
, and ContextPathServicesBuilder
?
Server
.builder()
.coroutineService("/prefix", myCoroutineService)
...
Let's add the extension methods in the next PR. ๐ https://github.com/line/armeria/issues/5671
Great job, @pinest94! ๐