armeria icon indicating copy to clipboard operation
armeria copied to clipboard
verified publisher icon line

Respond 408 status when the server didn't receive request fully until it's timed out

Open minwoox opened this issue 2 years ago • 3 comments

Currently, we always respond with 503 if a RequestTimeoutException is raised. However, we should send 408 status if the server didn't receive the request fully.

The 408 (Request Timeout) status code indicates that the server did not receive a complete request message within the time that it was prepared to wait.

https://httpwg.org/specs/rfc9110.html#status.408

Related: https://github.com/line/armeria/issues/5572

minwoox avatar Apr 08 '24 07:04 minwoox

Can I work on this?

thachlp avatar Apr 16 '24 10:04 thachlp

Hi, @thachlp! We are currently addressing some timeout-related issues, so I believe this task should be completed after that. I will inform you once the timeout issues have been resolved.

minwoox avatar Apr 16 '24 11:04 minwoox

Hi, @thachlp! We are currently addressing some timeout-related issues, so I believe this task should be completed after that. I will inform you once the timeout issues have been resolved.

Thanks

thachlp avatar Apr 16 '24 13:04 thachlp

@thachlp, Sorry I had to do this by myself because it's more complicated than I initially thought. 😓

minwoox avatar May 16 '24 06:05 minwoox

@thachlp, Sorry I had to do this by myself because it's more complicated than I initially thought. 😓

It is fine, thank you for information 🙇

thachlp avatar May 16 '24 09:05 thachlp

Closed by #5680

minwoox avatar Jun 13 '24 01:06 minwoox