armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Support `RpcService` based `Decorator` and `DecoratorFactoryFunction`

Open Dogacel opened this issue 1 year ago • 2 comments

Currently, DecoratorFactoryFunction and Decorator annotations only support HTTP-based decorators. It can be a good idea to support RPC-based decorators to be defined using those annotations and methods.

Dogacel avatar Feb 07 '24 19:02 Dogacel

It sounds like a good idea. One thing to note is that RpcService is only used for Thrift services. We have no plan for supporting decorators for gRPC services. It was introduced by Armeria because of the absence of interceptor or something similar in libthrift.

I know you heavily use gRPC for your services. Is this issue not your need but a general requirement for functionality?

ikhoon avatar Feb 13 '24 08:02 ikhoon

It sounds like a good idea. One thing to note is that RpcService is only used for Thrift services. We have no plan for supporting decorators for gRPC services. It was introduced by Armeria because of the absence of interceptor or something similar in libthrift.

I know you heavily use gRPC for your services. Is this issue not your need but a general requirement for functionality?

I unfortunately fallen into the naming trap. I don't need to use this function for Thrift. Feel free to close the issue if there is no meaning to support decorators in Thrift.

Dogacel avatar Feb 13 '24 14:02 Dogacel

I see. Please re-open when you need this feature.

ikhoon avatar Mar 18 '24 08:03 ikhoon