armeria icon indicating copy to clipboard operation
armeria copied to clipboard

Add auth-http-service example

Open opencroco opened this issue 5 years ago • 4 comments

add auth-http-service token authorization

  • Add an example class MyAuthHandler.java implements Authorizer Interface.
  • Add an example class Auth1aHandler.java implements Authorizer Interface.
  • Add an example class Auth2Handler.java implements Authorizer Interface.

opencroco avatar Nov 25 '20 10:11 opencroco

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 25 '20 10:11 CLAassistant

Codecov Report

Attention: Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.

Project coverage is 74.05%. Comparing base (9ae0968) to head (d98f184). Report is 1973 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/example/armeria/server/auth/Main.java 0.00% 35 Missing :warning:
...ava/example/armeria/server/auth/Auth1aHandler.java 0.00% 16 Missing :warning:
...java/example/armeria/server/auth/Auth2Handler.java 0.00% 6 Missing :warning:
...ava/example/armeria/server/auth/MyAuthHandler.java 0.00% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3195      +/-   ##
============================================
- Coverage     74.13%   74.05%   -0.08%     
+ Complexity    12877    12876       -1     
============================================
  Files          1119     1123       +4     
  Lines         48741    48801      +60     
  Branches       6229     6230       +1     
============================================
+ Hits          36132    36139       +7     
- Misses         9433     9477      +44     
- Partials       3176     3185       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 25 '20 11:11 codecov[bot]

Thank you very much for your first contribution! I believe this will be useful indeed for anyone who wants to implement authentication with AuthService. But first of all, would you mind updating README.md so it explains the example a little bit better?

trustin avatar Nov 26 '20 03:11 trustin

Thank you very much for your first contribution! I believe this will be useful indeed for anyone who wants to implement authentication with AuthService. But first of all, would you mind updating README.md so it explains the example a little bit better?

Of course,thanks for your reply and I will try to do better . I am pian to add more explaintion to "README.md" and make it look more detailed if get some advice.

opencroco avatar Nov 26 '20 11:11 opencroco