Juri Leino

Results 390 comments of Juri Leino

OK, so then have a look at the __test__ in this PR as it is __changed__ to address your review. > it does not fix other issues with XQuery Update....

Well it is the other changed file. And your review so far did __only__ address the removal of the __unnecessary__ call of copyOf. I would still like to hear why...

> No it isn't. It does not fully address my review and is still missing several things. I would need some more info on what you think is missing.

I retested this issue today just out of curiosity. | exist version | test with the above code | |----|----| | 6.2.0 | still affected | | 6.3.0-SNAPSHOT | still...

@PieterLamers Ah, thanks for clarifying what you meant by top-down! So, as I now understand you it is the location rather than the message that is wrong. The message should...

I just found out that wrapping `fn:not()` in a function works, too. ```xquery declare function local:wrappedNot($a) { not($a) }; (true(), true(), true(), false(), true())[local:wrappedNot(.)] ```

I created some [tests](https://gist.github.com/line-o/c06d1d7b8baf3ec4447c273f03726b54) on my way to this discovery. If you think they - or some of them - are useful, I can prepare a PR.

@wolfgangmm are `dom.dbx` and `structure.dbx` being rebuilt in eXist. If not when was this changed?

@ahenket I think this issue is addressed and fixed in the develop branch. Would you be able to test it with latest develop and confirm?