Peter Lindstrom

Results 240 comments of Peter Lindstrom

@jakirkham Thanks for the pointer. However, the "approve and run" button in question does not appear visible to me. I'm no t sure if that's some kind of repo configuration...

> I can add the PR support here, I think. Then you'll see the button John mentions. @jaimergp I should have mentioned that I already added workflows on PRs on...

> > We actually want this for our feature branches as well, not just develop. > > I was trying to have the workflows triggered for every push to `develop`...

> Also I'd like to see if you are interested in using Appveyor, given that we can simply configure Github Actions to run on Windows too. Thoughts? I'd be the...

@robertu94 I appreciate the contribution and would like to merge your PR, though we first need to find a workaround for the AppVeyor tests, which use CMAKE 3.16. I've been...

@robertu94 A quick update: This PR conflicts with other changes we've recently made on the `staging` branch. Some of your proposed changes have, however, been adopted in the latest commits...

Nothing to be fixed here--the code is correct and unary negation is perfectly defined for unsigned types. Surely VS is just being overly cautious and giving a warning, not an...

OK. I'm keeping the issue open for now as we may want to silence these compiler warnings.

@svdree-shell Thank you so much for this contribution--we've been wanting to support this capability for some time. Unfortunately, as also discussed on PR #232, this is not a great time...

> Hi @lindstro, would you then also prefer this PR to be targeted to the `staging` branch? In general, we favor the GitFlow model of developing new features on separate...