Andreas Lindhé

Results 105 issues of Andreas Lindhé

How am I supposed to read this comment and know what to do?? https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/values-vsphere.yaml#L26-L54 Please use nested comments, so it's _clear_ which parts are _comments_ and what is _commented out...

The chart creates objects of kind `ManagedChart` here: https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/templates/managedcharts.yaml#L3 There is no documentation for `ManagedChart` in the Rancher documentation: ![Searching docs for `ManagedChart`](https://github.com/rancher/cluster-template-examples/assets/7773090/6ca25bea-727b-4bf5-9474-302c69405c72) Therefore, it needs to be documented here...

The example for `values.yaml` in the README doesn't match the contents of the actual [`values.yaml`](https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/values.yaml). If the example from the README is up-to-date, I think those should be merged into...

* Remove unused `rancherValues` * Remove unused `chartValues` * Remove unused `controlPlaneConfig` * Remove unused `workerConfig` * Remove unused `upgradeStrategy` * Remove unused `enableNetworkPolicy`

What's meant with this comment? It makes it seem like setting a semver range is useless, because it picks up the latest version anyway! Also, it is very unclear as...

I tried installing this chart in Rancher 2.7.5 after removing the tgz and index files, and it seems like it works fine without them. Therefore, I think they should be...

In many places in the documentation for setting up automatically rotating certificates, a duration of just 24h or 48h is used. That seems very short, considering that `linkerd check` recommends...

Relates to https://github.com/argoproj/notifications-engine/issues/205 Checklist: * [x] Either (a) I've created an [enhancement proposal](https://github.com/argoproj/argo-cd/issues/new/choose) and discussed it with the community, (b) this is a bug fix, or (c) this does not...