Font options should not be written as shorthand

[markoradak]

Font options should not be written as shorthand as this is not officially supported in SVG and is invalid in any graphic editing software: https://github.com/lindell/JsBarcode/blob/19cdeea9a03c3cd863a74d074ed8f7d66825b718/src/renderers/svg.js#L93

Happy to do a pull request as it's bugging me I cannot use it as intended 😇

[lindell]

Thanks for the information, I did not that SVG font options are not supported. Can you link to any documentation about it? :)

But many browsers do actually render it. Removing it will break it for everyone that is using this library with font options to render it on a website. So removing it right now is not an option, but doing it for the next major version might be.

[chrisbenjamin]

@lindell Hey Johan, I would love to see this Update. I think the change won't break anything, because you actually don't change the logic. But it would work also in graphic programs.

You have to change the shorthand in regular syntax:

currently you have in the svg file: style="font: monospace 20px"

but it would be better this way: style="font-family:monospace; font-size:20px; font-weight:bold;"

I changed all appearances in my generated SVGs and I could open them afterwards in Sketch or Illustrator.

[lindell]

Thanks @chrisbenjamin for the clarification. I was under the impression that the solution was something else. This does indeed seem to be solvable without changing anything 🙂

[lindell]

I went to check this fix and read my original response again. The key is:

Removing it will break it for everyone that is using this library with font options

Right now, using fontOptions: "italic", as well as fontOptions: "bold" works. This is indeed a design mistake, but also something that will break backward compatibility if just changed to font-weight: ${options.fontOptions}

[gaegulee]

Do you have any plan to support fontOptions: "underline" ?