JsBarcode icon indicating copy to clipboard operation
JsBarcode copied to clipboard

Published 20 hours ago • verified publisher icon lindell

[Work in Progress] Jsbarcode v4

Open lindell opened this issue 5 years ago • 3 comments

This PR is here to easier have discussions about JsBarcode 4

lindell avatar Jan 19 '19 07:01 lindell

@lindell found that custom valid function is never invoked. https://github.com/lindell/JsBarcode/pull/278/files#diff-4f1d5fc97807024e2c3306aeaea72e4eL12 https://github.com/lindell/JsBarcode/pull/278/files#diff-4f1d5fc97807024e2c3306aeaea72e4eL28

SanichKotikov avatar Jan 20 '19 06:01 SanichKotikov

@SanichKotikov How would you feel about removing the valid function in favor of catching and checking if it is the InvalidInputException that is thrown? I thinking that may be a better solution, but I'm not sure.

lindell avatar Jan 20 '19 10:01 lindell

@lindell feel good :) Actually, I've never liked this valid function as a property.

SanichKotikov avatar Jan 20 '19 10:01 SanichKotikov