NumericExtensions.jl icon indicating copy to clipboard operation
NumericExtensions.jl copied to clipboard

Reexport NumericFuns?

Open garborg opened this issue 10 years ago • 5 comments

Was going to update JuliaStats/Distance.jl to require and use NumericFuns, but I noticed functors are still used in the docs and README here -- what do you think about re-exporting NumericFuns here?

DataFrames does it with DataArrays. It would mean requiring Reexport, and replacing using NumericFuns with using Reexport; @reexport using NumericFuns (and no longer having to use NumericFuns throughout the test directory).

garborg avatar May 02 '14 14:05 garborg

Thanks for updating Distance.jl! This can be closed if re-exporting happens or the README and docs are updated.

garborg avatar May 22 '14 17:05 garborg

Distance no longer depends on this package.

lindahua avatar May 22 '14 17:05 lindahua

Understood, but this issue isn't resolved:

Pkg.checkout("NumericExtensions"); using NumericExtensions; a2f = Abs2Fun()
ERROR: Abs2Fun not defined

README: Here, Abs2Fun and Add are typed functors provided by this package, etc., and no mention of NumericFuns anywhere.

garborg avatar May 22 '14 18:05 garborg

This is mainly a document issue. I reopen this until the documentation is fixed.

lindahua avatar May 22 '14 18:05 lindahua

Thanks, I wasn't sure whether whether or not NumericExtensions was going to export them.

garborg avatar May 22 '14 18:05 garborg