django-ft-cache icon indicating copy to clipboard operation
django-ft-cache copied to clipboard

Fix: unknown behavior names: binary, password, username

Open ivictbor opened this issue 4 years ago • 2 comments

When I tried to pass:

'default': {
        'BACKEND': 'django_ft_cache.FaultTolerantPyLibMCCache',
        'LOCATION': env.str('MEMC_URL'),
        'TIMEOUT': None,
        'OPTIONS': {
            'binary': True,
            'username': env.str('MEMC_USERNAME', None),
            'password': env.str('MEMC_PASSWORD', None),
        }

Package stopped working with

unknown behavior names: binary, password, username

Why did you use _behaviours ?

ivictbor avatar Aug 06 '20 09:08 ivictbor

This was a change in Django 2.0 and the library hasn't been updated to reflect that yet, https://github.com/django/django/blob/stable/2.0.x/django/core/cache/backends/memcached.py#L174-L177

Your change looks good, but we should do a major version bump and update HISTORY.rst with the backwards incompatible change and tox.ini so it is only testing against currently supported Django/Python versions.

ipmb avatar Aug 06 '20 13:08 ipmb

This was a change in Django 2.0 and the library hasn't been updated to reflect that yet, https://github.com/django/django/blob/stable/2.0.x/django/core/cache/backends/memcached.py#L174-L177

Your change looks good, but we should do a major version bump and update HISTORY.rst with the backwards incompatible change and tox.ini so it is only testing against currently supported Django/Python versions.

Thanks for clear explanations. I am using my version in production right now, noted tests failed because None in self._options, though when I don't pass OPTIONS in settings.py, works fine also for me

ivictbor avatar Aug 06 '20 13:08 ivictbor